Issue 10191014: Reland r6578 without changing the order of pages in the PageSpace::pages_ list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10191014: Reland r6578 without changing the order of pages in the PageSpace::pages_ list. (Closed)

Created:
8 years, 8 months ago by Vyacheslav Egorov (Google)

Modified:
8 years, 8 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Reland r6578 without changing the order of pages in the PageSpace::pages_ list. Linking newly allocated pages into the list's head causes popular pages to move further to the end of the list. This causes slowdown on the debug VM because method PageSpace::Contains has to do more probes for popular objects. R=iposva@google.com BUG=2660 Committed: https://code.google.com/p/dart/source/detail?r=6940

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -3 lines)			Patch
	M	runtime/vm/pages.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	runtime/vm/pages.cc	View		2 chunks	+27 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM -ip

Expand Messages | Collapse Messages