Issue 10191013: Add handling of the HTTP Date header

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10191013: Add handling of the HTTP Date header (Closed)

Created:
8 years, 8 months ago by Søren Gjesse

Modified:
8 years, 8 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add handling of the HTTP Date header R=ajohnsen@google.com BUG=none TEST=none Committed: https://code.google.com/p/dart/source/detail?r=6930

Patch Set 1 #

Total comments: 4

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+61 lines, -1 line)			Patch
M	runtime/bin/http.dart	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/bin/http_impl.dart	View	2 chunks	+27 lines, -1 line	4 comments	Download
M	tests/standalone/src/io/HttpHeadersTest.dart	View	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

LGTM https://chromiumcodereview.appspot.com/10191013/diff/1/runtime/bin/http_impl.dart File runtime/bin/http_impl.dart (right): https://chromiumcodereview.appspot.com/10191013/diff/1/runtime/bin/http_impl.dart#newcode74 runtime/bin/http_impl.dart:74: } Maybe add an explicit return null. https://chromiumcodereview.appspot.com/10191013/diff/1/runtime/bin/http_impl.dart#newcode93 ...

8 years, 8 months ago (2012-04-25 09:02:09 UTC) #2

Søren Gjesse

8 years, 8 months ago (2012-04-25 14:14:36 UTC) #3

https://chromiumcodereview.appspot.com/10191013/diff/1/runtime/bin/http_impl....
File runtime/bin/http_impl.dart (right):

https://chromiumcodereview.appspot.com/10191013/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:74: }
On 2012/04/25 09:02:09, ajohnsen wrote:
> Maybe add an explicit return null.

Done.

https://chromiumcodereview.appspot.com/10191013/diff/1/runtime/bin/http_impl....
runtime/bin/http_impl.dart:93: }
On 2012/04/25 09:02:09, ajohnsen wrote:
> Ditto.

Done.

Expand Messages | Collapse Messages