Issue 10179001: Use shorter names for constructor arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10179001: Use shorter names for constructor arguments. (Closed)

Created:
8 years, 8 months ago by floitsch

Modified:
8 years, 8 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use shorter names for constructor arguments. Committed: https://code.google.com/p/dart/source/detail?r=6849

Patch Set 2 : Cosmetic change (change order of then/else). #

Patch Set 3 : Make sure mangling is correct and update tests. #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -9 lines)			Patch
M	frog/tests/leg/src/ClassCodegenTest.dart	View	1 2	1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/compiler/implementation/emitter.dart	View	1	3 chunks	+11 lines, -5 lines	0 comments	Download
M	lib/compiler/implementation/namer.dart	View	1 2	1 chunk	+5 lines, -1 line	2 comments	Download
A	tests/language/src/Naming2Test.dart	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM https://chromiumcodereview.appspot.com/10179001/diff/1002/lib/compiler/implementation/namer.dart File lib/compiler/implementation/namer.dart (right): https://chromiumcodereview.appspot.com/10179001/diff/1002/lib/compiler/implementation/namer.dart#newcode68 lib/compiler/implementation/namer.dart:68: return '$proposedName\$'; This code very much looks like ...

8 years, 8 months ago (2012-04-23 18:38:15 UTC) #4

floitsch

8 years, 8 months ago (2012-04-25 08:42:24 UTC) #5

https://chromiumcodereview.appspot.com/10179001/diff/1002/lib/compiler/implem...
File lib/compiler/implementation/namer.dart (right):

https://chromiumcodereview.appspot.com/10179001/diff/1002/lib/compiler/implem...
lib/compiler/implementation/namer.dart:68: return '$proposedName\$';
On 2012/04/23 18:38:15, ngeoffray wrote:
> This code very much looks like JsName.getValid, should you use that instead?

Thanks. Addressed in CL 10223002.