Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 10178014: Copy lib/dom tests that use dart:html to lib/html. (Closed)

Created:
8 years, 7 months ago by podivilov
Modified:
8 years, 7 months ago
Reviewers:
vsm, Anton Muhin, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Copy lib/dom tests that use dart:html to lib/html. R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=7124

Patch Set 1 #

Total comments: 1

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2315 lines) Patch
D tests/dom/async_window_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/dom/audiocontext_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/dom/cache_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/dom/callbacks_test.dart View 1 chunk +0 lines, -11 lines 0 comments Download
D tests/dom/canvas_pixel_array_type_alias_test.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D tests/dom/canvas_test.dart View 1 chunk +0 lines, -90 lines 0 comments Download
D tests/dom/canvas_using_html_test.dart View 1 chunk +0 lines, -57 lines 0 comments Download
D tests/dom/cross_frame_test.dart View 1 chunk +0 lines, -25 lines 0 comments Download
D tests/dom/css_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/dom/document_test.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M tests/dom/dom.status View 3 chunks +2 lines, -70 lines 0 comments Download
D tests/dom/dom_constructors_test.dart View 1 chunk +0 lines, -12 lines 0 comments Download
D tests/dom/dom_isolates_test.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D tests/dom/domparser_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/dom/events_test.dart View 1 chunk +0 lines, -60 lines 0 comments Download
D tests/dom/exceptions_test.dart View 1 chunk +0 lines, -28 lines 0 comments Download
D tests/dom/hidden_dom_1_test.dart View 1 chunk +0 lines, -45 lines 0 comments Download
D tests/dom/hidden_dom_2_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D tests/dom/history_test.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/dom/htmlaudioelement_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/dom/htmlcollection_test.dart View 1 chunk +0 lines, -277 lines 0 comments Download
D tests/dom/htmlelement_test.dart View 1 chunk +0 lines, -91 lines 0 comments Download
D tests/dom/indexeddb_1_test.dart View 1 chunk +0 lines, -137 lines 0 comments Download
D tests/dom/indexeddb_2_test.dart View 1 chunk +0 lines, -91 lines 0 comments Download
D tests/dom/instance_of_test.dart View 1 chunk +0 lines, -55 lines 0 comments Download
D tests/dom/isolates_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D tests/dom/key_name_location_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/dom/messageevent_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/dom/native_gc_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/dom/performance_api_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/dom/request_animation_frame_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
D tests/dom/serialized_script_value_test.dart View 1 chunk +0 lines, -38 lines 0 comments Download
D tests/dom/storage_test.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D tests/dom/svg_1_test.dart View 1 chunk +0 lines, -30 lines 0 comments Download
D tests/dom/svg_2_test.dart View 1 chunk +0 lines, -48 lines 0 comments Download
D tests/dom/svg_3_test.dart View 1 chunk +0 lines, -128 lines 0 comments Download
D tests/dom/typed_arrays_1_test.dart View 1 chunk +0 lines, -42 lines 0 comments Download
D tests/dom/typed_arrays_2_test.dart View 1 chunk +0 lines, -79 lines 0 comments Download
D tests/dom/typed_arrays_3_test.dart View 1 chunk +0 lines, -41 lines 0 comments Download
D tests/dom/typed_arrays_4_test.dart View 1 chunk +0 lines, -43 lines 0 comments Download
D tests/dom/typing_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
D tests/dom/utils.dart View 1 chunk +0 lines, -61 lines 0 comments Download
D tests/dom/webgl_1_test.dart View 1 chunk +0 lines, -21 lines 0 comments Download
D tests/dom/websocket_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
D tests/dom/window_eq_test.dart View 1 chunk +0 lines, -14 lines 0 comments Download
D tests/dom/window_mangling_test.dart View 1 chunk +0 lines, -35 lines 0 comments Download
D tests/dom/window_nosuchmethod_test.dart View 1 chunk +0 lines, -54 lines 0 comments Download
D tests/dom/window_open_test.dart View 1 chunk +0 lines, -31 lines 0 comments Download
D tests/dom/xhr_test.dart View 1 chunk +0 lines, -22 lines 0 comments Download
D tests/dom/xsltprocessor_test.dart View 1 chunk +0 lines, -15 lines 0 comments Download
A + tests/html/async_window_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/audiocontext_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/cache_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/callbacks_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/canvas_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/canvas_using_html_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/cross_frame_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/css_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/document_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/dom_constructors_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/dom_isolates_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/domparser_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/events_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/exceptions_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/hidden_dom_1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/hidden_dom_2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/history_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/html/html.status View 1 4 chunks +73 lines, -2 lines 0 comments Download
A + tests/html/htmlaudioelement_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/htmlcollection_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/htmlelement_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/indexeddb_1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/indexeddb_2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/instance_of_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/isolates_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/key_name_location_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/messageevent_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/native_gc_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/performance_api_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/serialized_script_value_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/storage_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/svg_1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/svg_2_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/svg_3_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/html/typed_arrays_1_test.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/html/typed_arrays_2_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/html/typing_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/utils.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/webgl_1_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/websocket_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/window_eq_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/window_mangling_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/window_nosuchmethod_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/window_open_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/html/xsltprocessor_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
podivilov
8 years, 7 months ago (2012-04-27 15:15:54 UTC) #1
Anton Muhin
lgtm https://chromiumcodereview.appspot.com/10178014/diff/1/tests/html/html.status File tests/html/html.status (right): https://chromiumcodereview.appspot.com/10178014/diff/1/tests/html/html.status#newcode5 tests/html/html.status:5: audiocontext_test: Fail # Issue 2770 that marks the ...
8 years, 7 months ago (2012-04-27 15:20:29 UTC) #2
Anton Muhin
lgtm
8 years, 7 months ago (2012-04-27 15:20:30 UTC) #3
sra1
8 years, 7 months ago (2012-04-27 23:26:17 UTC) #4
looks good, but the tests should have been *copied* and then ported to dart:html

We still need the dart:dom tests until we are sure that for frog/dart2js
dart:html does not cause too much code bloat.

Please restore the dart:dom tests.

Powered by Google App Engine
This is Rietveld 408576698