Issue 10176006: Temporary disable notifications to allow Chrome roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10176006: Temporary disable notifications to allow Chrome roll. (Closed)

Created:
8 years, 8 months ago by Anton Muhin

Modified:
8 years, 8 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Temporary disable notifications to allow Chrome roll. TBR=podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=6834

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	lib/dom/scripts/fremontcutbuilder.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

podivilov

8 years, 8 months ago (2012-04-23 11:02:22 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10176006/diff/1/lib/dom/scripts/fremon...
File lib/dom/scripts/fremontcutbuilder.py (right):

https://chromiumcodereview.appspot.com/10176006/diff/1/lib/dom/scripts/fremon...
lib/dom/scripts/fremontcutbuilder.py:88: # TODO(antonm): Remove this filter.
Probably we should remove this todo, because this list appears to be quite handy
:)

Expand Messages | Collapse Messages