Issue 10174041: Increase test coverage for sha1 and sha256 by using standard test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10174041: Increase test coverage for sha1 and sha256 by using standard test (Closed)

Created:
8 years, 8 months ago by Mads Ager (google)

Modified:
8 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Increase test coverage for sha1 and sha256 by using standard test vectors. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=7009

Created: 8 years, 8 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+308 lines, -0 lines)			Patch
M	tests/lib/src/crypto/sha1Test.dart	View	2 chunks	+12 lines, -0 lines	0 comments	Download
A	tests/lib/src/crypto/sha1_short_test_vectors.dart	View	1 chunk	+142 lines, -0 lines	0 comments	Download
M	tests/lib/src/crypto/sha256Test.dart	View	2 chunks	+12 lines, -0 lines	0 comments	Download
A	tests/lib/src/crypto/sha256_short_test_vectors.dart	View	1 chunk	+142 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Mads Ager (google)

There are two more files but they are apparently too large for upload.

8 years, 8 months ago (2012-04-26 11:27:19 UTC) #2

lgtm - after checking the large files offline :-)