Issue 10174029: Use YAML as the format for the pubspec file.

Issue 10174029: Use YAML as the format for the pubspec file. (Closed)

Created:
8 years, 8 months ago by nweiz

Modified:
8 years, 8 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use YAML as the format for the pubspec file. Committed: https://code.google.com/p/dart/source/detail?r=6982

Patch Set 2 : Code review change #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -10 lines)			Patch
M	utils/pub/package.dart	View	1	1 chunk	+22 lines, -7 lines	0 comments	Download
M	utils/pub/pub.dart	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	utils/tests/pub/pub_tests.dart	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM after grouping the deps in the pubspec under "dependencies". https://chromiumcodereview.appspot.com/10174029/diff/1/utils/pub/package.dart File utils/pub/package.dart (right): https://chromiumcodereview.appspot.com/10174029/diff/1/utils/pub/package.dart#newcode119 ...

8 years, 8 months ago (2012-04-25 22:59:00 UTC) #2

nweiz

8 years, 8 months ago (2012-04-25 23:05:14 UTC) #3

https://chromiumcodereview.appspot.com/10174029/diff/1/utils/pub/package.dart
File utils/pub/package.dart (right):

https://chromiumcodereview.appspot.com/10174029/diff/1/utils/pub/package.dart...
utils/pub/package.dart:119: 'pubspec must be a YAML list of package names.');
On 2012/04/25 22:59:01, Bob Nystrom wrote:
> 'The pubspec...
> 
> just so it can be sentence cased.

Done.

https://chromiumcodereview.appspot.com/10174029/diff/1/utils/tests/pub/pub_te...
File utils/tests/pub/pub_tests.dart (right):

https://chromiumcodereview.appspot.com/10174029/diff/1/utils/tests/pub/pub_te...
utils/tests/pub/pub_tests.dart:73: file('pubspec', '- foo')
On 2012/04/25 22:59:01, Bob Nystrom wrote:
> Now that we have a real format, I would put the dependencies under a
> dependencies key like:
> 
> dependencies:
> - foo
> - bar
> 
> (I may have the YAML wrong here.)

Done.

Expand Messages | Collapse Messages