Issue 10174004: Update AnalysisServer to preserve DartC import prefixes

Issue 10174004: Update AnalysisServer to preserve DartC import prefixes (Closed)

Created:
8 years, 8 months ago by danrubel

Modified:
8 years, 8 months ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Update AnalysisServer to preserve DartC import prefixes Committed: https://code.google.com/p/dart/source/detail?r=6853

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+85 lines, -13 lines)			Patch
M	compiler/java/com/google/dart/compiler/parser/DartParser.java	View		1 chunk	+1 line, -1 line	0 comments	Download
A	compiler/java/com/google/dart/compiler/parser/DartPrefixParser.java	View		1 chunk	+43 lines, -0 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisServer.java	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java	View	1	4 chunks	+11 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/Library.java	View		5 chunks	+10 lines, -3 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/ParseFileTask.java	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/ParseLibraryFileTask.java	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/ResolveLibraryTask.java	View		3 chunks	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

LGTM https://chromiumcodereview.appspot.com/10174004/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java File editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java (right): https://chromiumcodereview.appspot.com/10174004/diff/1/editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java#newcode89 editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java:89: //DartParser parser = new DartParser(parserCtx, false, prefixes); Do ...

8 years, 8 months ago (2012-04-23 16:05:34 UTC) #2

danrubel

8 years, 8 months ago (2012-04-23 18:18:47 UTC) #3

https://chromiumcodereview.appspot.com/10174004/diff/1/editor/tools/plugins/c...
File
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java
(right):

https://chromiumcodereview.appspot.com/10174004/diff/1/editor/tools/plugins/c...
editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/AnalysisUtility.java:89:
//DartParser parser = new DartParser(parserCtx, false, prefixes);
On 2012/04/23 16:05:34, scheglov wrote:
> Do you need this?

Good eyes! Removed.

Expand Messages | Collapse Messages