Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 10173024: Change the error handling in dart:io (Closed)

Created:
8 years, 8 months ago by Søren Gjesse
Modified:
8 years, 8 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org, Bill Hesse, ahe
Visibility:
Public.

Description

Change the error handling in dart:io 1. Change the argument on all onError handlers from Exception to Dynamic 2. Throw an exception if an error ocours and there is no error handler present for handling it. For sockets there is the complication that an error on a socket is reported to the socket error handler, and each of the stream error handlers. The solution to this is to throw an exception if there was no error handler on either the socket or one of the streams. Fixed a number of bugs in tests revealed by errors no longer being silently ignored. R=ager@google.com BUG=none TEST=tests/standalone/src/io/* Committed: https://code.google.com/p/dart/source/detail?r=6994

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -183 lines) Patch
M runtime/bin/chunked_stream.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/directory.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/directory_impl.dart View 8 chunks +40 lines, -38 lines 0 comments Download
M runtime/bin/file.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/file_impl.dart View 31 chunks +57 lines, -78 lines 0 comments Download
M runtime/bin/http.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/http_impl.dart View 16 chunks +27 lines, -15 lines 0 comments Download
M runtime/bin/input_stream.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/list_stream_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/output_stream.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process_impl.dart View 6 chunks +15 lines, -13 lines 0 comments Download
M runtime/bin/socket.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/socket_impl.dart View 4 chunks +12 lines, -7 lines 0 comments Download
M runtime/bin/socket_stream_impl.dart View 3 chunks +19 lines, -14 lines 0 comments Download
M runtime/bin/stream_util.dart View 2 chunks +15 lines, -1 line 0 comments Download
M runtime/bin/string_stream.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/src/io/FileTest.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/standalone/src/io/HttpServerSocketTest.dart View 4 chunks +7 lines, -2 lines 0 comments Download
M tests/standalone/src/io/HttpShutdownTest.dart View 3 chunks +5 lines, -0 lines 0 comments Download
M tests/standalone/src/io/ProcessBrokenPipeTest.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Gjesse
8 years, 8 months ago (2012-04-25 13:21:54 UTC) #1
Mads Ager (google)
8 years, 8 months ago (2012-04-25 14:42:08 UTC) #2
LGTM!

No more silent failures. I like that.

Powered by Google App Engine
This is Rietveld 408576698