Issue 10173021: Add web socket protocol processor test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10173021: Add web socket protocol processor test (Closed)

Created:
8 years, 8 months ago by Søren Gjesse

Modified:
8 years, 8 months ago

Reviewers:
Anders Johnsen, Mads Ager (google)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add web socket protocol processor test Unit test of the web socket protocol processor. This test includes testing splitting a message into several frames. Fixed the bugs found by adding a test. R=ager@google.com, ajohnsen@google.com BUG=dart:2001 TEST=tests/standalone/src/io/WebSocketProtocolProcessorTest.dart Committed: https://code.google.com/p/dart/source/detail?r=7008

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+235 lines, -13 lines)			Patch
	M	runtime/bin/websocket_impl.dart	View		6 chunks	+17 lines, -13 lines	2 comments	Download
	A	tests/standalone/src/io/WebSocketProtocolProcessorTest.dart	View		1 chunk	+218 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

This is based on http://codereview.chromium.org/10205012/.

8 years, 8 months ago (2012-04-25 08:20:03 UTC) #2

Mads Ager (google)

LGTM! https://chromiumcodereview.appspot.com/10173021/diff/1/runtime/bin/websocket_impl.dart File runtime/bin/websocket_impl.dart (right): https://chromiumcodereview.appspot.com/10173021/diff/1/runtime/bin/websocket_impl.dart#newcode272 runtime/bin/websocket_impl.dart:272: // Check whether there is any payload. If ...

8 years, 8 months ago (2012-04-25 10:47:46 UTC) #3

Søren Gjesse

8 years, 8 months ago (2012-04-27 11:58:24 UTC) #4

https://chromiumcodereview.appspot.com/10173021/diff/1/runtime/bin/websocket_...
File runtime/bin/websocket_impl.dart (right):

https://chromiumcodereview.appspot.com/10173021/diff/1/runtime/bin/websocket_...
runtime/bin/websocket_impl.dart:272: // Check whether there is any payload. If
not indicate empty message or
On 2012/04/25 10:47:46, Mads Ager wrote:
> Finish comment. :)

Done.

Expand Messages | Collapse Messages