Issue 10173014: A 'fix' for issue 2671, toRadixString.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10173014: A 'fix' for issue 2671, toRadixString. (Closed)

Created:
8 years, 8 months ago by srdjan

Modified:
8 years, 8 months ago

Reviewers:
floitsch, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org, floitsch

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

A 'fix' for issue 2671, toRadixString. Committed: https://code.google.com/p/dart/source/detail?r=6948

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	runtime/lib/double.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

This seems the right thing to do and we eliminate the exception being thrown.

8 years, 8 months ago (2012-04-25 00:08:22 UTC) #1

hausner

LGTM under the assumption that it's ok to silently throw away the fractional part of ...

8 years, 8 months ago (2012-04-25 00:16:03 UTC) #2

floitsch

LGTM too. Personally I would move toRadixString on integers anyways (see issue 1895).

8 years, 8 months ago (2012-04-25 06:59:02 UTC) #3

srdjan

8 years, 8 months ago (2012-04-25 14:59:20 UTC) #4

On 2012/04/25 00:16:03, hausner wrote:
> LGTM under the assumption that it's ok to silently throw away the fractional
> part of a number. The library folks may have an issue with that.

I believe it is OK, since there is not appropriate representation for doubles. I
agree with Florian it it would be best to move it to integers. This CL
eliminates the abortion of a program.

Expand Messages | Collapse Messages