Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 10171019: Add pub (and by extension YAML) to the SDK. (Closed)

Created:
8 years, 8 months ago by Bob Nystrom
Modified:
8 years, 7 months ago
Reviewers:
nweiz, dgrove, kasperl
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add pub (and by extension YAML) to the SDK. Committed: https://code.google.com/p/dart/source/detail?r=7301

Patch Set 1 #

Patch Set 2 : Rebase. #

Total comments: 6

Patch Set 3 : Move YAML under pub. #

Patch Set 4 : Use Copy(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -13 lines) Patch
M tools/create_sdk.py View 1 2 3 9 chunks +28 lines, -10 lines 0 comments Download
M utils/pub/io.dart View 1 2 2 chunks +10 lines, -3 lines 0 comments Download
A utils/pub/sdk/pub View 1 chunk +6 lines, -0 lines 0 comments Download
A utils/pub/sdk/pub.bat View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Bob Nystrom
Adds pub (under util) and YAML (which pub needs, under lib) to the SDK. Also ...
8 years, 8 months ago (2012-04-27 22:47:57 UTC) #1
nweiz
lgtm
8 years, 8 months ago (2012-04-27 23:49:42 UTC) #2
kasperl
DBC https://chromiumcodereview.appspot.com/10171019/diff/2001/utils/pub/sdk/pub File utils/pub/sdk/pub (right): https://chromiumcodereview.appspot.com/10171019/diff/2001/utils/pub/sdk/pub#newcode1 utils/pub/sdk/pub:1: #!/bin/sh It seems like we have more components ...
8 years, 7 months ago (2012-04-28 08:34:25 UTC) #3
dgrove
http://codereview.chromium.org/10171019/diff/2001/tools/create_sdk.py File tools/create_sdk.py (right): http://codereview.chromium.org/10171019/diff/2001/tools/create_sdk.py#newcode48 tools/create_sdk.py:48: # ......yaml/ I think yaml should be a subdirectory ...
8 years, 7 months ago (2012-04-28 13:26:06 UTC) #4
Bob Nystrom
http://codereview.chromium.org/10171019/diff/2001/tools/create_sdk.py File tools/create_sdk.py (right): http://codereview.chromium.org/10171019/diff/2001/tools/create_sdk.py#newcode48 tools/create_sdk.py:48: # ......yaml/ On 2012/04/28 13:26:06, dgrove wrote: > I ...
8 years, 7 months ago (2012-04-30 17:30:56 UTC) #5
dgrove
lgtm This will be LGTM once yaml is moved inside pub. http://codereview.chromium.org/10171019/diff/2001/tools/create_sdk.py File tools/create_sdk.py (right): ...
8 years, 7 months ago (2012-05-01 09:21:48 UTC) #6
nweiz
8 years, 7 months ago (2012-05-01 18:12:54 UTC) #7
http://codereview.chromium.org/10171019/diff/2001/tools/create_sdk.py
File tools/create_sdk.py (right):

http://codereview.chromium.org/10171019/diff/2001/tools/create_sdk.py#newcode48
tools/create_sdk.py:48: # ......yaml/
On 2012/05/01 09:21:48, dgrove wrote:
> I don't think this is a commonly-desired library for dart developers. If I'm
> wrong, we can move it to lib later. For the time being, though, I think it
> should be within pub.
> 
> On 2012/04/30 17:30:56, Bob Nystrom wrote:
> > On 2012/04/28 13:26:06, dgrove wrote:
> > > I think yaml should be a subdirectory under util/pub . (and yaml should be
a
> > > subdirectory of pub in the repo, as well).
> > 
> > It seemed consistent to me to put it next to JSON, UTF, and URI which are
also
> > general-purpose libs for parsing publicly-specced formats. Is there a reason
> > you'd want to limit YAML to pub?
> 

I don't understand why we wouldn't put a general-purpose library in the lib
directory. YAML is a reasonably widely-used language. The presence of an
easily-available parser may also help the dart community standardize on it for a
configuration format.

Powered by Google App Engine
This is Rietveld 408576698