Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 10170040: test rename overhaul: step 11 - tests/utils (Closed)

Created:
8 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
8 years, 7 months ago
CC:
reviews_dartlang.org, Ivan Posva
Visibility:
Public.

Description

test rename overhaul: step 11 - tests/utils Committed: https://code.google.com/p/dart/source/detail?r=7117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -3259 lines) Patch
A + tests/utils/dartdoc_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
A + tests/utils/dummy.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/utils/dummy_compiler_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/utils/json_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/utils/markdown_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D tests/utils/src/DartdocTest.dart View 1 chunk +0 lines, -224 lines 0 comments Download
D tests/utils/src/DummyCompilerTest.dart View 1 chunk +0 lines, -51 lines 0 comments Download
D tests/utils/src/JsonTest.dart View 1 chunk +0 lines, -107 lines 0 comments Download
D tests/utils/src/MarkdownTest.dart View 1 chunk +0 lines, -797 lines 0 comments Download
D tests/utils/src/UriTest.dart View 1 chunk +0 lines, -93 lines 0 comments Download
D tests/utils/src/Utf8Test.dart View 1 chunk +0 lines, -50 lines 0 comments Download
D tests/utils/src/YamlTest.dart View 1 chunk +0 lines, -1826 lines 0 comments Download
D tests/utils/src/dummy.dart View 1 chunk +0 lines, -18 lines 0 comments Download
D tests/utils/src/test_utils.dart View 1 chunk +0 lines, -53 lines 0 comments Download
D tests/utils/test_config.dart View 1 chunk +0 lines, -15 lines 0 comments Download
A + tests/utils/test_utils.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/utils/uri_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/utils/utf8_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/utils/utils.status View 1 chunk +10 lines, -10 lines 0 comments Download
A + tests/utils/yaml_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/test.dart View 3 chunks +1 line, -3 lines 0 comments Download
M tools/test-runtime.dart View 3 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Siggi Cherem (dart-lang)
8 years, 8 months ago (2012-04-27 23:33:06 UTC) #1
Siggi Cherem (dart-lang)
8 years, 8 months ago (2012-04-27 23:33:37 UTC) #2
Bob Nystrom
LGTM!
8 years, 8 months ago (2012-04-28 00:02:28 UTC) #3
Emily Fortuna
LGTM!!
8 years, 8 months ago (2012-04-28 00:15:14 UTC) #4
Mads Ager (google)
I think something bad happened on this commit. Missing a merge? In my client I ...
8 years, 7 months ago (2012-04-30 09:51:54 UTC) #5
Mads Ager (google)
On 2012/04/30 09:51:54, Mads Ager wrote: > I think something bad happened on this commit. ...
8 years, 7 months ago (2012-04-30 09:55:16 UTC) #6
Siggi Cherem (dart-lang)
8 years, 7 months ago (2012-04-30 16:35:16 UTC) #7
On 2012/04/30 09:55:16, Mads Ager wrote:
> On 2012/04/30 09:51:54, Mads Ager wrote:
> > I think something bad happened on this commit. Missing a merge? In my client
I
> > lost the lib/crypto tests. We need to carefully verify the number of tests
run
> > on each of these commits. I'll restore the lib/crypto tests.
> 
> Restored as part of:
> 
> https://chromiumcodereview.appspot.com//10170027

Thanks Mads!

This seems like a bad merge to me too. Sorry about that.

Powered by Google App Engine
This is Rietveld 408576698