Issue 10170008: fixes css tests, now they can also run in browsers too.

Issue 10170008: fixes css tests, now they can also run in browsers too. (Closed)

Created:
8 years, 8 months ago by Siggi Cherem (dart-lang)

Modified:
8 years, 8 months ago

Reviewers:
terry

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

fixes css tests, now they can also run in browsers too. Committed: https://code.google.com/p/dart/source/detail?r=6857

Patch Set 2 : #

Total comments: 3

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -27 lines)			Patch
M	utils/css/tokenizer.dart	View	1	7 chunks	+11 lines, -15 lines	0 comments	Download
M	utils/css/tokenizer_base.dart	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	utils/tests/css/css.status	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	utils/tests/css/src/DeclarationTest.dart	View		1 chunk	+1 line, -0 lines	3 comments	Download
M	utils/tests/css/src/ExpressionTest.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	utils/tests/css/src/SelectorLiteralTest.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://chromiumcodereview.appspot.com/10170008/diff/1007/utils/tests/css/src/DeclarationTest.dart File utils/tests/css/src/DeclarationTest.dart (right): https://chromiumcodereview.appspot.com/10170008/diff/1007/utils/tests/css/src/DeclarationTest.dart#newcode5 utils/tests/css/src/DeclarationTest.dart:5: #library("DeclarationrTest"); this is why the tests failed in frog/dart2js ...

8 years, 8 months ago (2012-04-20 18:01:36 UTC) #1

terry

LGTM. Just one spelling issue https://chromiumcodereview.appspot.com/10170008/diff/1007/utils/tests/css/src/DeclarationTest.dart File utils/tests/css/src/DeclarationTest.dart (right): https://chromiumcodereview.appspot.com/10170008/diff/1007/utils/tests/css/src/DeclarationTest.dart#newcode5 utils/tests/css/src/DeclarationTest.dart:5: #library("DeclarationrTest"); Should this be ...

8 years, 8 months ago (2012-04-23 18:24:02 UTC) #2

Siggi Cherem (dart-lang)

8 years, 8 months ago (2012-04-23 19:43:45 UTC) #3

tjx

https://chromiumcodereview.appspot.com/10170008/diff/1007/utils/tests/css/src...
File utils/tests/css/src/DeclarationTest.dart (right):

https://chromiumcodereview.appspot.com/10170008/diff/1007/utils/tests/css/src...
utils/tests/css/src/DeclarationTest.dart:5: #library("DeclarationrTest");
On 2012/04/23 18:24:02, terry wrote:
> Should this be DeclarationTest?

Done.

Expand Messages | Collapse Messages