Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 10168024: frog: allow optional arguments in implicit method closures. (Closed)

Created:
8 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
8 years, 8 months ago
Reviewers:
sra1, kasperl
CC:
reviews_dartlang.org, Bob Nystrom
Visibility:
Public.

Description

frog: allow optional arguments in implicit method closures. This fixes http://dartbug.com/854, but not bug 282. We need either fixing 282 or this to implement a better API in unittest.dart (which works in the vm and dart2js). Committed: https://code.google.com/p/dart/source/detail?r=6850

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M frog/gen.dart View 1 chunk +7 lines, -1 line 1 comment Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
8 years, 8 months ago (2012-04-21 03:20:44 UTC) #1
sra1
DBC. lgtm - I nearly made this change several times since it is so easy. ...
8 years, 8 months ago (2012-04-21 03:33:14 UTC) #2
sra1
Please run presubmit to regenerate minfrog.
8 years, 8 months ago (2012-04-21 03:33:56 UTC) #3
kasperl
8 years, 8 months ago (2012-04-23 05:32:44 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698