Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Issue 10168022: Enhanced HTML test look & feel, thanks to John Evans (Closed)

Created:
8 years, 8 months ago by Jennifer Messerly
Modified:
8 years, 8 months ago
CC:
reviews_dartlang.org, john evans
Visibility:
Public.

Description

Enhanced HTML test look & feel, thanks to John Evans https://github.com/dart-lang/dart/pull/3 Much of this was originally reviewed by me in pull #1: https://github.com/dart-lang/dart/pull/1 Committed: https://code.google.com/p/dart/source/detail?r=6817

Patch Set 1 #

Patch Set 2 : 80 cols & misc style #

Patch Set 3 : newline #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+369 lines, -3 lines) Patch
A lib/unittest/html_enhanced_config.dart View 1 2 1 chunk +363 lines, -0 lines 2 comments Download
M lib/unittest/test_case.dart View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jennifer Messerly
LGTM. I added Siggi in case he has more thoughts on it with respect to ...
8 years, 8 months ago (2012-04-20 23:29:21 UTC) #1
prujohn
On 2012/04/20 23:29:21, John Messerly wrote: > > Also I made the code break at ...
8 years, 8 months ago (2012-04-20 23:40:54 UTC) #2
Siggi Cherem (dart-lang)
https://chromiumcodereview.appspot.com/10168022/diff/4001/lib/unittest/html_enhanced_config.dart File lib/unittest/html_enhanced_config.dart (right): https://chromiumcodereview.appspot.com/10168022/diff/4001/lib/unittest/html_enhanced_config.dart#newcode232 lib/unittest/html_enhanced_config.dart:232: static bool get _isIE() => document.window.navigator.userAgent.contains('MSIE'); still a few ...
8 years, 8 months ago (2012-04-21 00:02:13 UTC) #3
Siggi Cherem (dart-lang)
Very cool to see this coming in!
8 years, 8 months ago (2012-04-21 00:02:45 UTC) #4
Siggi Cherem (dart-lang)
8 years, 8 months ago (2012-04-24 23:26:30 UTC) #5
https://chromiumcodereview.appspot.com/10168022/diff/4001/lib/unittest/html_e...
File lib/unittest/html_enhanced_config.dart (right):

https://chromiumcodereview.appspot.com/10168022/diff/4001/lib/unittest/html_e...
lib/unittest/html_enhanced_config.dart:133: .replaceAll("(?:[^a-z0-9
]|(?<=['\"])s)",'_')
Can you help me understand this expression better. The non-capture and
lookbehind is a bit confusing.

I run into a test where groups used parenthesis, and I'd like to fix this to
also replace them with _.

Powered by Google App Engine
This is Rietveld 408576698