Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 10168010: test rename overhaul: step 1 peg. (Closed)

Created:
8 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
8 years, 8 months ago
Reviewers:
Bob Nystrom, sra1
CC:
reviews_dartlang.org, Bill Hesse, ahe
Visibility:
Public.

Description

test rename overhaul: step 1 peg. The overhaul consists of: - use _tests.dart notation, instead of xTest.dart - use the directory setup (no more test_config, yay!) Committed: https://code.google.com/p/dart/source/detail?r=6815

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -371 lines) Patch
M tools/test.dart View 1 3 chunks +2 lines, -5 lines 0 comments Download
M utils/tests/peg/peg.status View 1 chunk +13 lines, -4 lines 0 comments Download
A + utils/tests/peg/peg_tests.dart View 1 chunk +2 lines, -1 line 0 comments Download
D utils/tests/peg/src/PegTest.dart View 1 chunk +0 lines, -346 lines 0 comments Download
D utils/tests/peg/test_config.dart View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Siggi Cherem (dart-lang)
Mainly reapplying what Bob tried before. Peter - I'm cc'ing you because I've added a ...
8 years, 8 months ago (2012-04-20 18:37:02 UTC) #1
Siggi Cherem (dart-lang)
8 years, 8 months ago (2012-04-20 19:02:32 UTC) #2
Bob Nystrom
Nit, but LGTM. https://chromiumcodereview.appspot.com/10168010/diff/1/tools/test.dart File tools/test.dart (right): https://chromiumcodereview.appspot.com/10168010/diff/1/tools/test.dart#newcode59 tools/test.dart:59: 'utils/tests/peg', Keep in alphabetical order.
8 years, 8 months ago (2012-04-20 21:34:01 UTC) #3
Siggi Cherem (dart-lang)
thanks! https://chromiumcodereview.appspot.com/10168010/diff/1/tools/test.dart File tools/test.dart (right): https://chromiumcodereview.appspot.com/10168010/diff/1/tools/test.dart#newcode59 tools/test.dart:59: 'utils/tests/peg', On 2012/04/20 21:34:01, Bob Nystrom wrote: > ...
8 years, 8 months ago (2012-04-20 22:56:19 UTC) #4
sra1
lgtm
8 years, 8 months ago (2012-04-20 22:59:50 UTC) #5
ahe
8 years, 8 months ago (2012-04-23 09:13:54 UTC) #6
FWIW, I think these tests belong in tests/utils.

Powered by Google App Engine
This is Rietveld 408576698