Issue 10164009: Don't upload data to appengine.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10164009: Don't upload data to appengine. (Closed)

Created:
8 years, 8 months ago by Emily Fortuna

Modified:
8 years, 8 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, ricow1

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Don't upload data to appengine. Committed: https://code.google.com/p/dart/source/detail?r=6813

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -401 lines)			Patch
	M	tools/testing/perf_testing/run_perf_tests.py	View	1	24 chunks	+57 lines, -401 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://chromiumcodereview.appspot.com/10164009/diff/2001/tools/testing/perf_testing/run_perf_tests.py File tools/testing/perf_testing/run_perf_tests.py (left): https://chromiumcodereview.appspot.com/10164009/diff/2001/tools/testing/perf_testing/run_perf_tests.py#oldcode861 tools/testing/perf_testing/run_perf_tests.py:861: return map(DromaeoTester.legalize_filename, benchmarks) This might mess up some ...

8 years, 8 months ago (2012-04-20 19:13:33 UTC) #2

Emily Fortuna

8 years, 8 months ago (2012-04-20 19:47:17 UTC) #3

https://chromiumcodereview.appspot.com/10164009/diff/2001/tools/testing/perf_...
File tools/testing/perf_testing/run_perf_tests.py (left):

https://chromiumcodereview.appspot.com/10164009/diff/2001/tools/testing/perf_...
tools/testing/perf_testing/run_perf_tests.py:861: return
map(DromaeoTester.legalize_filename, benchmarks)
On 2012/04/20 19:13:33, vsm wrote:
> This might mess up some of the existing data files fwiw.  But otherwise ok.

Ah, in that case, I'll leave it as it was, just so we don't have strange symbols
in our file names.

Expand Messages | Collapse Messages

Issue 10164009: Don't upload data to appengine. (Closed)

Description

Patch Set 1 : #

Patch Set 2 : #

Messages