Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 10163004: Revert "Support passing an environment variable map to child processes." (Closed)

Created:
8 years, 8 months ago by Mads Ager (google)
Modified:
8 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Support passing an environment variable map to child processes." Apparently the code or the test is broken on Mac. R=sgjesse@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -245 lines) Patch
M runtime/bin/builtin_natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/process.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/bin/process.cc View 5 chunks +34 lines, -65 lines 0 comments Download
M runtime/bin/process.dart View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/bin/process_impl.dart View 4 chunks +0 lines, -22 lines 0 comments Download
M runtime/bin/process_linux.cc View 3 chunks +4 lines, -24 lines 0 comments Download
M runtime/bin/process_macos.cc View 3 chunks +4 lines, -24 lines 0 comments Download
M runtime/bin/process_win.cc View 3 chunks +2 lines, -31 lines 0 comments Download
D tests/standalone/src/io/PrintEnv.dart View 1 chunk +0 lines, -9 lines 0 comments Download
D tests/standalone/src/io/ProcessEnvironmentTest.dart View 1 chunk +0 lines, -57 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 8 months ago (2012-04-20 12:53:05 UTC) #1
Søren Gjesse
8 years, 8 months ago (2012-04-20 12:56:29 UTC) #2
lgtm

Sad :-(

Powered by Google App Engine
This is Rietveld 408576698