Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10162004: Hack around issue with is checks against type variables. (Closed)

Created:
8 years, 8 months ago by kasperl
Modified:
8 years, 8 months ago
Reviewers:
karlklose, floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Hack around issue with is checks against type variables. R=floitsch@google.com,karlklose@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6791

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M lib/compiler/implementation/ssa/builder.dart View 1 chunk +13 lines, -5 lines 0 comments Download
M tests/co19/co19-leg.status View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kasperl
8 years, 8 months ago (2012-04-20 11:58:27 UTC) #1
floitsch
LGTM. https://chromiumcodereview.appspot.com/10162004/diff/1/lib/compiler/implementation/ssa/builder.dart File lib/compiler/implementation/ssa/builder.dart (right): https://chromiumcodereview.appspot.com/10162004/diff/1/lib/compiler/implementation/ssa/builder.dart#newcode1786 lib/compiler/implementation/ssa/builder.dart:1786: stack.add(graph.addConstantBool(true)); maybe emit a warning?
8 years, 8 months ago (2012-04-20 12:04:34 UTC) #2
karlklose
8 years, 8 months ago (2012-04-23 07:01:59 UTC) #3 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698