Issue 10155027: Support custom to native conversions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10155027: Support custom to native conversions. (Closed)

Created:
8 years, 8 months ago by podivilov

Modified:
8 years, 8 months ago

Reviewers:
Anton Muhin, antonm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Support custom to native conversions. R=antonm@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=6898

Patch Set 2 : . #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -34 lines)			Patch
M	lib/dom/scripts/generator.py	View		3 chunks	+14 lines, -13 lines	0 comments	Download
M	lib/dom/scripts/systemnative.py	View	1	1 chunk	+24 lines, -15 lines	0 comments	Download
M	lib/dom/templates/dom/native/cpp_header.template	View		1 chunk	+2 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

https://chromiumcodereview.appspot.com/10155027/diff/1/lib/dom/scripts/systemnative.py File lib/dom/scripts/systemnative.py (right): https://chromiumcodereview.appspot.com/10155027/diff/1/lib/dom/scripts/systemnative.py#newcode407 lib/dom/scripts/systemnative.py:407: intermediate_emitter = emitter.Emitter() this two level emitting might be ...

8 years, 8 months ago (2012-04-24 14:05:51 UTC) #2

podivilov

8 years, 8 months ago (2012-04-24 14:30:33 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 10155027: Support custom to native conversions. (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages