Use 'frog' in apidoc. Also fix broken dependencies.

Use 'frog' in apidoc. Also fix broken dependencies.

Second attempt, now with Windows support.

Committed: https://code.google.com/p/dart/source/detail?r=6873

[ahe, 2012-04-24 11:41:39]

This is the same as CL 10174006. However these files are different:

frog/scripts/bootstrap/frog_bootstrap_wrapper.py
frog/scripts/bootstrap/frog_wrapper.py

[ngeoffray, 2012-04-24 12:50:08]

LGTM

[Bob Nystrom, 2012-04-24 16:03:58]

Couple of nits.

https://chromiumcodereview.appspot.com/10141009/diff/1/dart/lib/dartdoc/dartd...
File dart/lib/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/10141009/diff/1/dart/lib/dartdoc/dartd...
dart/lib/dartdoc/dartdoc.dart:181: print('$message.');
This is a bit strange. Why not just put the "." in the previous string?

https://chromiumcodereview.appspot.com/10141009/diff/1/dart/utils/apidoc/apid...
File dart/utils/apidoc/apidoc.dart (right):

https://chromiumcodereview.appspot.com/10141009/diff/1/dart/utils/apidoc/apid...
dart/utils/apidoc/apidoc.dart:67: if (compilerPath === null) {
== null

[ahe, 2012-04-25 08:26:55]

Hi Bob,

Thank you for your comments.

Cheers,
Peter

https://chromiumcodereview.appspot.com/10141009/diff/1/dart/lib/dartdoc/dartd...
File dart/lib/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/10141009/diff/1/dart/lib/dartdoc/dartd...
dart/lib/dartdoc/dartdoc.dart:181: print('$message.');
On 2012/04/24 16:03:58, Bob Nystrom wrote:
> This is a bit strange. Why not just put the "." in the previous string?

I'm not sure how to format exception messages: Should there be a trailing
period, and who is responsible for adding it?

Any advice on this?

https://chromiumcodereview.appspot.com/10141009/diff/1/dart/utils/apidoc/apid...
File dart/utils/apidoc/apidoc.dart (right):

https://chromiumcodereview.appspot.com/10141009/diff/1/dart/utils/apidoc/apid...
dart/utils/apidoc/apidoc.dart:67: if (compilerPath === null) {
On 2012/04/24 16:03:58, Bob Nystrom wrote:
> == null

As I mentioned in the other code review, I'm sticking with === for comparing to
null. I have been burned too many times by this, and I program for the *current*
semantics. If (and I stress if) we are able to implement the new (proposed)
semantics, I expect that we'll have to do some automated global rewrite of all
our sources.

I'm taking the stance that I'll see it before I believe it :-)

[Bob Nystrom, 2012-04-25 18:03:41]

https://chromiumcodereview.appspot.com/10141009/diff/1/dart/lib/dartdoc/dartd...
File dart/lib/dartdoc/dartdoc.dart (right):

https://chromiumcodereview.appspot.com/10141009/diff/1/dart/lib/dartdoc/dartd...
dart/lib/dartdoc/dartdoc.dart:181: print('$message.');
On 2012/04/25 08:26:55, ahe wrote:
> On 2012/04/24 16:03:58, Bob Nystrom wrote:
> > This is a bit strange. Why not just put the "." in the previous string?
> 
> I'm not sure how to format exception messages: Should there be a trailing
> period, and who is responsible for adding it?
> 
> Any advice on this?

I'd say whatever initially creates the exception message should just make it a
complete sentence then. I don't think there's a lot of value in having a
fragment message floating around.

https://chromiumcodereview.appspot.com/10141009/diff/1/dart/utils/apidoc/apid...
File dart/utils/apidoc/apidoc.dart (right):

https://chromiumcodereview.appspot.com/10141009/diff/1/dart/utils/apidoc/apid...
dart/utils/apidoc/apidoc.dart:67: if (compilerPath === null) {
On 2012/04/25 08:26:55, ahe wrote:
> On 2012/04/24 16:03:58, Bob Nystrom wrote:
> > == null
> 
> As I mentioned in the other code review, I'm sticking with === for comparing
to
> null. I have been burned too many times by this, and I program for the
*current*
> semantics. If (and I stress if) we are able to implement the new (proposed)
> semantics, I expect that we'll have to do some automated global rewrite of all
> our sources.
> 
> I'm taking the stance that I'll see it before I believe it :-)

Ha, suit yourself. Live in fear! :)