Issue 10140025: Adjust tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10140025: Adjust tests. (Closed)

Created:
8 years, 8 months ago by Anton Muhin

Modified:
8 years, 8 months ago

Reviewers:
podivilov, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Adjust tests. TBR=podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=6882

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -5 lines)			Patch
M	client/tests/client/dom/CanvasTest.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	client/tests/client/dom/CanvasUsingHtmlTest.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	client/tests/client/dom/InstanceOfTest.dart	View	1 chunk	+1 line, -1 line	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

https://chromiumcodereview.appspot.com/10140025/diff/1/client/tests/client/dom/InstanceOfTest.dart File client/tests/client/dom/InstanceOfTest.dart (right): https://chromiumcodereview.appspot.com/10140025/diff/1/client/tests/client/dom/InstanceOfTest.dart#newcode48 client/tests/client/dom/InstanceOfTest.dart:48: Expect.isTrue(bytes is Uint8ClampedArray); I haven't look into this in ...

8 years, 8 months ago (2012-04-24 16:06:58 UTC) #3

Anton Muhin

8 years, 8 months ago (2012-04-24 16:13:41 UTC) #4

https://chromiumcodereview.appspot.com/10140025/diff/1/client/tests/client/do...
File client/tests/client/dom/InstanceOfTest.dart (right):

https://chromiumcodereview.appspot.com/10140025/diff/1/client/tests/client/do...
client/tests/client/dom/InstanceOfTest.dart:48: Expect.isTrue(bytes is
Uint8ClampedArray);
Yes, that's very probably the case.  I've tried to regenerate libs, but maybe I
did something wrong.  I am on it anyway

On 2012/04/24 16:06:59, sigmund wrote:
> I haven't look into this in detail, but is it possible that this change breaks
> the chrome tests in windows and mac?
> 
> See:
>
http://chromegw.corp.google.com/i/client.dart/builders/web-chrome-mac/builds/...

Expand Messages | Collapse Messages