Support for same prefix for multiple imports.

Support for same prefix for multiple imports.


R=zundel@google.com
BUG=
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=6819

[zundel, 2012-04-20 22:05:38]

http://codereview.chromium.org/10139017/diff/1/compiler/java/com/google/dart/...
File compiler/java/com/google/dart/compiler/resolver/LibraryPrefixElement.java
(right):

http://codereview.chromium.org/10139017/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/resolver/LibraryPrefixElement.java:1: //
Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
date

http://codereview.chromium.org/10139017/diff/1/compiler/java/com/google/dart/...
File
compiler/java/com/google/dart/compiler/resolver/LibraryPrefixElementImplementation.java
(right):

http://codereview.chromium.org/10139017/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/resolver/LibraryPrefixElementImplementation.java:1:
// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
date

http://codereview.chromium.org/10139017/diff/1/compiler/java/com/google/dart/...
File compiler/java/com/google/dart/compiler/resolver/Scope.java (right):

http://codereview.chromium.org/10139017/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/resolver/Scope.java:41: // One prefix cab
be used to import several libraries.
s/cab/can/

http://codereview.chromium.org/10139017/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/resolver/Scope.java:42: // So, we wrap
LibraryElement's into LibraryPrefixElement
s/LibraryElement's/LibraryElements/

http://codereview.chromium.org/10139017/diff/1/compiler/javatests/com/google/...
File
compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
(right):

http://codereview.chromium.org/10139017/diff/1/compiler/javatests/com/google/...
compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java:594:
assertErrors(errors);
should add a negative test that if a library contains the same names you get a
compile-time error.

http://codereview.chromium.org/10139017/diff/1/compiler/javatests/com/google/...
File
compiler/javatests/com/google/dart/compiler/end2end/inc/MemoryLibrarySource.java
(right):

http://codereview.chromium.org/10139017/diff/1/compiler/javatests/com/google/...
compiler/javatests/com/google/dart/compiler/end2end/inc/MemoryLibrarySource.java:69:
//      @Override
remove commented out code?

http://codereview.chromium.org/10139017/diff/1/compiler/javatests/com/google/...
File
compiler/javatests/com/google/dart/compiler/parser/TruncatedSourceParserTest.java
(right):

http://codereview.chromium.org/10139017/diff/1/compiler/javatests/com/google/...
compiler/javatests/com/google/dart/compiler/parser/TruncatedSourceParserTest.java:127:
if
("true".equals(System.getProperty("analysis_skip_TruncatedSourceParserTest"))) {
who is using this?

[scheglov, 2012-04-20 23:23:57]

https://chromiumcodereview.appspot.com/10139017/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/LibraryPrefixElement.java
(right):

https://chromiumcodereview.appspot.com/10139017/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/LibraryPrefixElement.java:1: //
Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
On 2012/04/20 22:05:38, zundel wrote:
> date

Done.

https://chromiumcodereview.appspot.com/10139017/diff/1/compiler/java/com/goog...
File
compiler/java/com/google/dart/compiler/resolver/LibraryPrefixElementImplementation.java
(right):

https://chromiumcodereview.appspot.com/10139017/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/LibraryPrefixElementImplementation.java:1:
// Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
On 2012/04/20 22:05:38, zundel wrote:
> date

Done.

https://chromiumcodereview.appspot.com/10139017/diff/1/compiler/java/com/goog...
File compiler/java/com/google/dart/compiler/resolver/Scope.java (right):

https://chromiumcodereview.appspot.com/10139017/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/Scope.java:41: // One prefix cab
be used to import several libraries.
On 2012/04/20 22:05:38, zundel wrote:
> s/cab/can/

Done.

https://chromiumcodereview.appspot.com/10139017/diff/1/compiler/java/com/goog...
compiler/java/com/google/dart/compiler/resolver/Scope.java:42: // So, we wrap
LibraryElement's into LibraryPrefixElement
On 2012/04/20 22:05:38, zundel wrote:
> s/LibraryElement's/LibraryElements/

Done.

https://chromiumcodereview.appspot.com/10139017/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java
(right):

https://chromiumcodereview.appspot.com/10139017/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/end2end/inc/IncrementalCompilation2Test.java:594:
assertErrors(errors);
On 2012/04/20 22:05:38, zundel wrote:
> should add a negative test that if a library contains the same names you get a
> compile-time error.

Done.

https://chromiumcodereview.appspot.com/10139017/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/end2end/inc/MemoryLibrarySource.java
(right):

https://chromiumcodereview.appspot.com/10139017/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/end2end/inc/MemoryLibrarySource.java:69:
//      @Override
On 2012/04/20 22:05:38, zundel wrote:
> remove commented out code?

Done.

https://chromiumcodereview.appspot.com/10139017/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/parser/TruncatedSourceParserTest.java
(right):

https://chromiumcodereview.appspot.com/10139017/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/parser/TruncatedSourceParserTest.java:127:
if
("true".equals(System.getProperty("analysis_skip_TruncatedSourceParserTest"))) {
Me.
This test recently become very unfriendly.
It takes 90% of total analysis test suite, but if I don't change parser (and I
don't), I'd not like to pay this price.

[zundel, 2012-04-21 00:41:17]

lgtm

https://chromiumcodereview.appspot.com/10139017/diff/5001/compiler/java/com/g...
File
compiler/java/com/google/dart/compiler/resolver/LibraryPrefixElementImplementation.java
(right):

https://chromiumcodereview.appspot.com/10139017/diff/5001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/resolver/LibraryPrefixElementImplementation.java:21:
//    scope = new Scope(name, parent.getLibrary()) {
remove commented out code

https://chromiumcodereview.appspot.com/10139017/diff/5001/compiler/java/com/g...
File compiler/java/com/google/dart/compiler/resolver/Scope.java (right):

https://chromiumcodereview.appspot.com/10139017/diff/5001/compiler/java/com/g...
compiler/java/com/google/dart/compiler/resolver/Scope.java:43: //    if (element
instanceof LibraryElement) {
remove commented out code.