Issue 10134070: Get get_drt working on Windows, take 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10134070: Get get_drt working on Windows, take 2. (Closed)

Created:
8 years, 8 months ago by Emily Fortuna

Modified:
8 years, 7 months ago

Reviewers:
vsm, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Get get_drt working on Windows, take 2. Committed: https://code.google.com/p/dart/source/detail?r=6983

Patch Set 1 : #

Total comments: 4

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -17 lines)			Patch
	M	tools/get_drt.py	View		5 chunks	+26 lines, -15 lines	4 comments	Download
	M	tools/testing/perf_testing/run_perf_tests.py	View		2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

https://chromiumcodereview.appspot.com/10134070/diff/5001/tools/get_drt.py File tools/get_drt.py (right): https://chromiumcodereview.appspot.com/10134070/diff/5001/tools/get_drt.py#newcode163 tools/get_drt.py:163: # built in zip utility. :-/ This branch is ...

8 years, 8 months ago (2012-04-25 23:26:13 UTC) #1

Siggi Cherem (dart-lang)

https://chromiumcodereview.appspot.com/10134070/diff/5001/tools/get_drt.py File tools/get_drt.py (left): https://chromiumcodereview.appspot.com/10134070/diff/5001/tools/get_drt.py#oldcode157 tools/get_drt.py:157: if result != 0: why did this check go ...

8 years, 8 months ago (2012-04-25 23:41:00 UTC) #3

Emily Fortuna

8 years, 7 months ago (2012-04-26 15:51:48 UTC) #4

https://chromiumcodereview.appspot.com/10134070/diff/5001/tools/get_drt.py
File tools/get_drt.py (left):

https://chromiumcodereview.appspot.com/10134070/diff/5001/tools/get_drt.py#ol...
tools/get_drt.py:157: if result != 0:
On 2012/04/25 23:41:00, sigmund wrote:
> why did this check go away?

Ooops, I took it out when I was debugging and forgot to put it back in. I've
added it to a new CL.

Expand Messages | Collapse Messages