Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issue 10134052: Remove unused class DirectoryTestSuite from test script. (Closed)

Created:
8 years, 8 months ago by Bill Hesse
Modified:
8 years, 8 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove unused class DirectoryTestSuite from test script. BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6933

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -51 lines) Patch
M tools/test.dart View 1 chunk +4 lines, -3 lines 1 comment Download
M tools/testing/dart/test_suite.dart View 3 chunks +2 lines, -48 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
8 years, 8 months ago (2012-04-25 10:44:30 UTC) #1
Mads Ager (google)
I'm all for removing this extra thing. However, see comment. https://chromiumcodereview.appspot.com/10134052/diff/1/tools/test.dart File tools/test.dart (right): https://chromiumcodereview.appspot.com/10134052/diff/1/tools/test.dart#newcode54 ...
8 years, 8 months ago (2012-04-25 10:51:15 UTC) #2
Bill Hesse
I think we should move almost everything here. I didn't introduce this, and I thought ...
8 years, 8 months ago (2012-04-25 10:55:55 UTC) #3
Mads Ager (google)
8 years, 8 months ago (2012-04-25 11:05:04 UTC) #4
LGTM

We really need to clean this up though. I see no reason to have these two
registration methods. I would be in favor of removing the special registration
for these two suites. If we want to do this we need to do it for all of the ones
where it makes sense.

Powered by Google App Engine
This is Rietveld 408576698