Fix a bug that caused private names from an imported library to be included in the name scope of th…

Fix a bug that caused private names from an imported library to be included in the name scope of the importing library (issue 2651)
Committed: https://code.google.com/p/dart/source/detail?r=6908

[scheglov, 2012-04-24 18:32:11]

LGTM

http://codereview.chromium.org/10134035/diff/1/compiler/java/com/google/dart/...
File compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java
(right):

http://codereview.chromium.org/10134035/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java:100:
if (includePrivate || !element.getName().startsWith("_")) {
May be use com.google.dart.compiler.ast.DartIdentifier.isPrivateName(String)
But may be this is simple enough to keep as is.

http://codereview.chromium.org/10134035/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java:101:
declare(element, listener, scope);
indentation

[Brian Wilkerson, 2012-04-24 18:47:24]

http://codereview.chromium.org/10134035/diff/1/compiler/java/com/google/dart/...
File compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java
(right):

http://codereview.chromium.org/10134035/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java:100:
if (includePrivate || !element.getName().startsWith("_")) {
Done

http://codereview.chromium.org/10134035/diff/1/compiler/java/com/google/dart/...
compiler/java/com/google/dart/compiler/resolver/TopLevelElementBuilder.java:101:
declare(element, listener, scope);
Done