Issue 10128001: Constructors for IDBKeyRange

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10128001: Constructors for IDBKeyRange (Closed)

Created:
8 years, 8 months ago by sra1

Modified:
8 years, 8 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, dart-dom-team_google.com

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Constructors for IDBKeyRange Removed static methods on interface and replaced with constructors. This is dom only, html to come later. Committed: https://code.google.com/p/dart/source/detail?r=6770

Patch Set 1 : #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : merge #

Patch Set 4 : Sort #sources #

Patch Set 5 : merge #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+239 lines, -147 lines)			Patch
M	client/tests/client/client.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	lib/dom/dom.dart	View		2 chunks	+20 lines, -9 lines	0 comments	Download
M	lib/dom/frog/dom_frog.dart	View	1 2 3	5 chunks	+110 lines, -69 lines	0 comments	Download
M	lib/dom/idl/dart/dart.idl	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	lib/dom/src/dummy_FactoryProviders.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	lib/dom/src/frog_IDBKeyRangeFactoryProvider.dart	View		1 chunk	+47 lines, -0 lines	0 comments	Download
M	lib/dom/src/native_FactoryProviders.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	lib/dom/src/native_FactoryProvidersImplementation.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	lib/dom/templates/dom/frog/frog_dom.darttemplate	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
A	lib/dom/templates/dom/interface/interface_IDBKeyRange.darttemplate	View		1 chunk	+18 lines, -0 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		2 chunks	+0 lines, -47 lines	0 comments	Download
M	lib/html/frog/html_frog.dart	View		2 chunks	+0 lines, -20 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

vsm

8 years, 8 months ago (2012-04-19 03:49:44 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10128001/diff/1012/lib/dom/templates/d...
File lib/dom/templates/dom/frog/frog_dom.darttemplate (right):

https://chromiumcodereview.appspot.com/10128001/diff/1012/lib/dom/templates/d...
lib/dom/templates/dom/frog/frog_dom.darttemplate:19:
#source('../src/frog_IDBKeyRangeFactoryProvider.dart');
Swap previous and next for alpha order.

Expand Messages | Collapse Messages