Support passing an environment variable map to child processes.

Support passing an environment variable map to child processes.

Fix minor type warning in test.

R=sgjesse@google.com
BUG=dartbug.com/2193
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=6794

[Søren Gjesse, 2012-04-19 12:45:54]

lgtm

https://chromiumcodereview.appspot.com/10127008/diff/1/runtime/bin/process_im...
File runtime/bin/process_impl.dart (right):

https://chromiumcodereview.appspot.com/10127008/diff/1/runtime/bin/process_im...
runtime/bin/process_impl.dart:78: if (key is !String || value is !String) {
Maybe we should allow any type on value and just rely on tpString. E.g. numbers
makes sense.

https://chromiumcodereview.appspot.com/10127008/diff/1/runtime/bin/process_im...
runtime/bin/process_impl.dart:78: if (key is !String || value is !String) {
Check that the key does not contain illegal charcters e.g. =.

https://chromiumcodereview.appspot.com/10127008/diff/1/runtime/bin/process_im...
runtime/bin/process_impl.dart:78: if (key is !String || value is !String) {
For both key and value.toString() is there any charset restriction?

https://chromiumcodereview.appspot.com/10127008/diff/1/runtime/bin/process_wi...
File runtime/bin/process_win.cc (right):

https://chromiumcodereview.appspot.com/10127008/diff/1/runtime/bin/process_wi...
runtime/bin/process_win.cc:602: printf("%s\n", environment[i]);
Debugging print

[Mads Ager (google), 2012-04-20 12:24:51]

https://chromiumcodereview.appspot.com/10127008/diff/1/runtime/bin/process_im...
File runtime/bin/process_impl.dart (right):

https://chromiumcodereview.appspot.com/10127008/diff/1/runtime/bin/process_im...
runtime/bin/process_impl.dart:78: if (key is !String || value is !String) {
On 2012/04/19 12:45:55, Søren Gjesse wrote:
> Maybe we should allow any type on value and just rely on tpString. E.g.
numbers
> makes sense.

I would like to start out requiring this to be a Map<String, String>. toString
is not guaranteed to return a string so these checks are needed anyway. We can
of course perform toString and then check the result but I think it is fair to
force the programmer to make environment-variable values strings.

https://chromiumcodereview.appspot.com/10127008/diff/1/runtime/bin/process_im...
runtime/bin/process_impl.dart:78: if (key is !String || value is !String) {
On 2012/04/19 12:45:55, Søren Gjesse wrote:
> Check that the key does not contain illegal charcters e.g. =.

An early check for that would make sense, thanks. Added.

https://chromiumcodereview.appspot.com/10127008/diff/1/runtime/bin/process_im...
runtime/bin/process_impl.dart:78: if (key is !String || value is !String) {
On 2012/04/19 12:45:55, Søren Gjesse wrote:
> For both key and value.toString() is there any charset restriction?

Yes, at this point if you go out of ASCII range the Windows implementation will
not like that. I will add a note on that. The VM does not behave nicely in this
situation. It does not return an error when Dart_NewString() is passed invalid
utf8 data. I have filed issue 2663 on that. When that is fixed it should fail
somewhat gracefully.

https://chromiumcodereview.appspot.com/10127008/diff/1/runtime/bin/process_wi...
File runtime/bin/process_win.cc (right):

https://chromiumcodereview.appspot.com/10127008/diff/1/runtime/bin/process_wi...
runtime/bin/process_win.cc:602: printf("%s\n", environment[i]);
On 2012/04/19 12:45:55, Søren Gjesse wrote:
> Debugging print

Removed.