Issue 10123013: Make frog.py --leg work on Windows.

Issue 10123013: Make frog.py --leg work on Windows. (Closed)

Created:
8 years, 8 months ago by ahe

Modified:
8 years, 8 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, compiler-dev_dartlang.org, Mads Ager (google), Bill Hesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make frog.py --leg work on Windows. Committed: https://code.google.com/p/dart/source/detail?r=6782

Patch Set 2 : Add link to MS blog post about Windows file names and URIs #

Total comments: 3

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -50 lines)			Patch
M	dart/frog/frog_leg.dart	View		3 chunks	+4 lines, -3 lines	0 comments	Download
A	dart/lib/compiler/implementation/filenames.dart	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	dart/tests/co19/co19-leg.status	View		10 chunks	+58 lines, -47 lines	3 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

Changes to status file necessary to run tests on Windows as we are not building ...

8 years, 8 months ago (2012-04-19 16:14:39 UTC) #1

kasperl

LGTM. https://chromiumcodereview.appspot.com/10123013/diff/4001/dart/tests/co19/co19-leg.status File dart/tests/co19/co19-leg.status (right): https://chromiumcodereview.appspot.com/10123013/diff/4001/dart/tests/co19/co19-leg.status#newcode15 dart/tests/co19/co19-leg.status:15: [ $compiler == dart2js ] Keep some whitespace ...

8 years, 8 months ago (2012-04-20 06:28:10 UTC) #3

ahe

https://chromiumcodereview.appspot.com/10123013/diff/4001/dart/tests/co19/co19-leg.status File dart/tests/co19/co19-leg.status (right): https://chromiumcodereview.appspot.com/10123013/diff/4001/dart/tests/co19/co19-leg.status#newcode15 dart/tests/co19/co19-leg.status:15: [ $compiler == dart2js ] On 2012/04/20 06:28:10, kasperl ...

8 years, 8 months ago (2012-04-20 06:48:30 UTC) #4

kasperl

8 years, 8 months ago (2012-04-20 06:54:54 UTC) #5

https://chromiumcodereview.appspot.com/10123013/diff/4001/dart/tests/co19/co1...
File dart/tests/co19/co19-leg.status (right):

https://chromiumcodereview.appspot.com/10123013/diff/4001/dart/tests/co19/co1...
dart/tests/co19/co19-leg.status:15: [ $compiler == dart2js ]
On 2012/04/20 06:48:30, ahe wrote:
> On 2012/04/20 06:28:10, kasperl wrote:
> > Keep some whitespace before the [section] marker?
> 
> I'm using the lack of whitespace to indicate that the comment above applies. 

Ah, okay. That actually makes sense :-)

Expand Messages | Collapse Messages