Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 10123009: Fix mangling of local variables when their name conflict with Dart2JS's temporaries. (Closed)

Created:
8 years, 8 months ago by ngeoffray
Modified:
8 years, 8 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org, kasperl, karlklose, ahe, Lasse Reichstein Nielsen
Visibility:
Public.

Description

Fix mangling of local variables when their name conflict with Dart2JS's temporaries. Committed: https://code.google.com/p/dart/source/detail?r=6742

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -10 lines) Patch
M lib/compiler/implementation/ssa/codegen.dart View 1 2 3 4 chunks +20 lines, -10 lines 0 comments Download
A tests/language/src/TempManglingTest.dart View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
8 years, 8 months ago (2012-04-19 12:11:21 UTC) #1
ngeoffray
PTAL
8 years, 8 months ago (2012-04-19 12:33:54 UTC) #2
floitsch
8 years, 8 months ago (2012-04-19 13:13:38 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698