Remove restriction when computing instructions that can be generate at use site.

Remove restriction when computing instructions that can be generate at use site.
Committed: https://code.google.com/p/dart/source/detail?r=6685

[ngeoffray, 2012-04-18 12:28:11]

I can't find the reason why we would not allow an instruction that is 1) not
generate at use site or 2) not only used by phis, to try to make its inputs
generate at use site.

I spotted the problem while looking at generated code for swarm. This change
saves us 40k on the output of swarm (which is roughly around 1.2M).

[floitsch, 2012-04-18 13:13:24]

LGTM.

https://chromiumcodereview.appspot.com/10119006/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/codegen_helpers.dart (right):

https://chromiumcodereview.appspot.com/10119006/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/codegen_helpers.dart:139: if
(findInInputs(instruction)) tryGenerateAtUseSite(instruction);
as discussed change this to findInInputsAndPopNonMatching.
and keep the 'else assert(...isEmpty())'.

[ngeoffray, 2012-04-18 13:17:19]

Thanks Florian

https://chromiumcodereview.appspot.com/10119006/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/codegen_helpers.dart (right):

https://chromiumcodereview.appspot.com/10119006/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/codegen_helpers.dart:139: if
(findInInputs(instruction)) tryGenerateAtUseSite(instruction);
On 2012/04/18 13:13:24, floitsch wrote:
> as discussed change this to findInInputsAndPopNonMatching.
> and keep the 'else assert(...isEmpty())'.

Done.