Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(854)

Issue 10116025: Introduce CompositeIDLTypeInfo and clean up the code that deals with sequences. (Closed)

Created:
8 years, 8 months ago by podivilov
Modified:
8 years, 8 months ago
Reviewers:
Anton Muhin, antonm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Introduce CompositeIDLTypeInfo and clean up the code that deals with sequences. R=antonm@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=6735

Patch Set 1 #

Patch Set 2 : . #

Total comments: 6

Patch Set 3 : Address comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -36 lines) Patch
M lib/dom/scripts/generator.py View 1 2 6 chunks +26 lines, -36 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
podivilov
8 years, 8 months ago (2012-04-18 12:25:04 UTC) #1
Anton Muhin
https://chromiumcodereview.appspot.com/10116025/diff/3001/lib/dom/scripts/generator.py File lib/dom/scripts/generator.py (right): https://chromiumcodereview.appspot.com/10116025/diff/3001/lib/dom/scripts/generator.py#newcode444 lib/dom/scripts/generator.py:444: if self._dart_type: return self._dart_type or self._idl_type or it's too ...
8 years, 8 months ago (2012-04-18 14:25:53 UTC) #2
podivilov
PTAL. http://codereview.chromium.org/10116025/diff/3001/lib/dom/scripts/generator.py File lib/dom/scripts/generator.py (right): http://codereview.chromium.org/10116025/diff/3001/lib/dom/scripts/generator.py#newcode444 lib/dom/scripts/generator.py:444: if self._dart_type: On 2012/04/18 14:25:53, antonmuhin wrote: > ...
8 years, 8 months ago (2012-04-18 14:56:26 UTC) #3
Anton Muhin
8 years, 8 months ago (2012-04-18 15:03:24 UTC) #4
LGTM!

Powered by Google App Engine
This is Rietveld 408576698