Issue 10115034: Add a missing arity check for top-level methods in Dart_Invoke.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10115034: Add a missing arity check for top-level methods in Dart_Invoke. (Closed)

Created:
8 years, 8 months ago by turnidge

Modified:
8 years, 8 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Add a missing arity check for top-level methods in Dart_Invoke. Add a new EXPECT_ERROR macro to make it easier to verify meaningful error messages in tests. Committed: https://code.google.com/p/dart/source/detail?r=6705

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -7 lines)			Patch
M	vm/dart_api_impl.cc	View		1 chunk	+7 lines, -2 lines	0 comments	Download
M	vm/dart_api_impl_test.cc	View		4 chunks	+15 lines, -0 lines	0 comments	Download
M	vm/unit_test.h	View	1 2 3 4	1 chunk	+23 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages