Issue 10108020: Fix bug 1991, variable resolution in string interpolation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10108020: Fix bug 1991, variable resolution in string interpolation (Closed)

Created:
8 years, 8 months ago by hausner

Modified:
8 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug 1991, variable resolution in string interpolation Check to make sure string interpolation expressions cannot contain type parameter names. Committed: https://code.google.com/p/dart/source/detail?r=6645

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -3 lines)			Patch
	M	runtime/vm/parser.cc	View	1	1 chunk	+15 lines, -2 lines	0 comments	Download
	M	tests/co19/co19-runtime.status	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm http://codereview.chromium.org/10108020/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): http://codereview.chromium.org/10108020/diff/1/runtime/vm/parser.cc#newcode7101 runtime/vm/parser.cc:7101: TypeParameter& type_param = TypeParameter::ZoneHandle( TypeParameter::Handle(....)

8 years, 8 months ago (2012-04-17 16:06:07 UTC) #2

hausner

8 years, 8 months ago (2012-04-17 16:10:56 UTC) #3

http://codereview.chromium.org/10108020/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

http://codereview.chromium.org/10108020/diff/1/runtime/vm/parser.cc#newcode7101
runtime/vm/parser.cc:7101: TypeParameter& type_param =
TypeParameter::ZoneHandle(
On 2012/04/17 16:06:07, asiva wrote:
> TypeParameter::Handle(....)

Thanks, done. The dangers of mindless copy-paste.

Expand Messages | Collapse Messages