Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 10107010: Map IDBAny and IDBKey to Dynamic (Closed)

Created:
8 years, 8 months ago by sra1
Modified:
8 years, 8 months ago
Reviewers:
vsm, Anton Muhin, podivilov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Map IDBAny and IDBKey to Dynamic Specialize printing of Dynamic depending on context. Interfaces try to print it as /*IDLType*/ in operation signatures. Generated C++ is unchanged. Replace the arg_info tuple with a ParamInfo object. Rename arg_infos to param_infos. void postMessage(Dynamic message, [List messagePorts]); -> void postMessage(/*SerializedScriptValue*/ message, [List messagePorts]); String createObjectURL(var blob_OR_stream); -> String createObjectURL(blob_OR_stream); final Dynamic key; -> final /*IDBKey*/ key; Dynamic strokeStyle; -> var strokeStyle; Committed: https://code.google.com/p/dart/source/detail?r=6665

Patch Set 1 : #

Total comments: 2

Patch Set 2 : merge #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+474 lines, -413 lines) Patch
M client/tests/client/client.status View 1 chunk +0 lines, -7 lines 0 comments Download
M lib/dom/dom.dart View 26 chunks +48 lines, -48 lines 0 comments Download
M lib/dom/frog/dom_frog.dart View 50 chunks +95 lines, -95 lines 0 comments Download
M lib/dom/scripts/generator.py View 1 10 chunks +113 lines, -42 lines 0 comments Download
M lib/dom/scripts/systemfrog.py View 3 chunks +12 lines, -8 lines 0 comments Download
M lib/dom/scripts/systemhtml.py View 5 chunks +9 lines, -10 lines 0 comments Download
M lib/dom/scripts/systeminterface.py View 1 chunk +8 lines, -5 lines 0 comments Download
M lib/dom/scripts/systemnative.py View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/dom/scripts/systemwrapping.py View 5 chunks +10 lines, -10 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 57 chunks +90 lines, -99 lines 0 comments Download
M lib/html/frog/html_frog.dart View 44 chunks +87 lines, -87 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sra1
8 years, 8 months ago (2012-04-17 06:39:18 UTC) #1
Anton Muhin
Pavel kindly volunteered to help.
8 years, 8 months ago (2012-04-17 15:47:29 UTC) #2
vsm
LGTM https://chromiumcodereview.appspot.com/10107010/diff/4001/lib/dom/dom.dart File lib/dom/dom.dart (right): https://chromiumcodereview.appspot.com/10107010/diff/4001/lib/dom/dom.dart#newcode5143 lib/dom/dom.dart:5143: interface IDBKey { Does it still make sense ...
8 years, 8 months ago (2012-04-17 20:08:13 UTC) #3
sra1
8 years, 8 months ago (2012-04-17 23:26:19 UTC) #4
https://chromiumcodereview.appspot.com/10107010/diff/4001/lib/dom/dom.dart
File lib/dom/dom.dart (right):

https://chromiumcodereview.appspot.com/10107010/diff/4001/lib/dom/dom.dart#ne...
lib/dom/dom.dart:5143: interface IDBKey {
On 2012/04/17 20:08:13, vsm wrote:
> Does it still make sense to generate this interface?

I will see if it has any documentation implications and remove it later if not.

Powered by Google App Engine
This is Rietveld 408576698