Issue 10106019: Truley compute direct subtypes of native classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10106019: Truley compute direct subtypes of native classes. (Closed)

Created:
8 years, 8 months ago by ngeoffray

Modified:
8 years, 8 months ago

Reviewers:
floitsch, kasperl, sra1

CC:
reviews_dartlang.org, kasperl, karlklose, ahe, Lasse Reichstein Nielsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Truley compute direct subtypes of native classes. Committed: https://code.google.com/p/dart/source/detail?r=6625

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -4 lines)			Patch
	M	lib/compiler/implementation/native_emitter.dart	View		3 chunks	+7 lines, -4 lines	0 comments	Download
	M	lib/compiler/implementation/native_handler.dart	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://chromiumcodereview.appspot.com/10106019/diff/1/lib/compiler/implementation/native_handler.dart File lib/compiler/implementation/native_handler.dart (right): https://chromiumcodereview.appspot.com/10106019/diff/1/lib/compiler/implementation/native_handler.dart#newcode31 lib/compiler/implementation/native_handler.dart:31: cls.superclass, That's a lot of indentation.

8 years, 8 months ago (2012-04-17 11:28:02 UTC) #2

ngeoffray

8 years, 8 months ago (2012-04-17 11:37:50 UTC) #3

Thanks Kasper

https://chromiumcodereview.appspot.com/10106019/diff/1/lib/compiler/implement...
File lib/compiler/implementation/native_handler.dart (right):

https://chromiumcodereview.appspot.com/10106019/diff/1/lib/compiler/implement...
lib/compiler/implementation/native_handler.dart:31: cls.superclass,
On 2012/04/17 11:28:02, kasperl wrote:
> That's a lot of indentation.

Done.

Expand Messages | Collapse Messages

Issue 10106019: Truley compute direct subtypes of native classes. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages