Issue 10105031: Check number of type arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10105031: Check number of type arguments. (Closed)

Created:
8 years, 8 months ago by karlklose

Modified:
8 years, 8 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Check number of type arguments. Committed: https://code.google.com/p/dart/source/detail?r=6675

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove accidental edits. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -41 lines)			Patch
M	frog/tests/leg/src/mock_compiler.dart	View	1	1 chunk	+0 lines, -4 lines	0 comments	Download
M	lib/compiler/implementation/compiler.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/elements/elements.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/enqueue.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View	1	4 chunks	+20 lines, -23 lines	0 comments	Download
M	lib/compiler/implementation/warnings.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	tests/co19/co19-leg.status	View		1 chunk	+0 lines, -8 lines	0 comments	Download
M	tests/language/language-leg.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ahe

8 years, 8 months ago (2012-04-18 09:09:54 UTC) #2

LGTM!

https://chromiumcodereview.appspot.com/10105031/diff/1/frog/tests/leg/src/Res...
File frog/tests/leg/src/ResolverTest.dart (left):

https://chromiumcodereview.appspot.com/10105031/diff/1/frog/tests/leg/src/Res...
frog/tests/leg/src/ResolverTest.dart:99: 
Removing these lines does not help me :-)

https://chromiumcodereview.appspot.com/10105031/diff/1/lib/compiler/implement...
File lib/compiler/implementation/elements/elements.dart (right):

https://chromiumcodereview.appspot.com/10105031/diff/1/lib/compiler/implement...
lib/compiler/implementation/elements/elements.dart:721: ClassElement
ensureResolved(Compiler compiler) {
Long term, I would like to get these kinds of method removed from the element
hierarchy.

Expand Messages | Collapse Messages