Issue 10103009: Implement implicit interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10103009: Implement implicit interfaces (Closed)

Created:
8 years, 8 months ago by hausner

Modified:
8 years, 8 months ago

Reviewers:
regis

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement implicit interfaces Amazingly, this small change is all it seems to take to implement implicit interfaces. Committed: https://code.google.com/p/dart/source/detail?r=6607

Patch Set 3 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -45 lines)			Patch
M	runtime/vm/class_finalizer.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 2	1 chunk	+39 lines, -40 lines	0 comments	Download
M	tests/co19/co19-runtime.status	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	tests/language/language.status	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

regis

LGTM http://codereview.chromium.org/10103009/diff/3001/runtime/vm/object.cc File runtime/vm/object.cc (right): http://codereview.chromium.org/10103009/diff/3001/runtime/vm/object.cc#newcode1538 runtime/vm/object.cc:1538: // Check for 'direct super type' in the ...

8 years, 8 months ago (2012-04-16 22:14:52 UTC) #2

hausner

8 years, 8 months ago (2012-04-16 23:19:09 UTC) #3

Thanks.

http://codereview.chromium.org/10103009/diff/3001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

http://codereview.chromium.org/10103009/diff/3001/runtime/vm/object.cc#newcod...
runtime/vm/object.cc:1538: // Check for 'direct super type' in the case of an
interface and check for
On 2012/04/16 22:14:52, regis wrote:
> You could clarify the comment:
> ... in the case of an interface, i.e. other.is_interface(), or of an implicit
> interface, i.e. !other.is_interface(), and ...

Done.

Expand Messages | Collapse Messages

Issue 10103009: Implement implicit interfaces (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages