Issue 10095017: added printWarnings option to HtmlDiff

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10095017: added printWarnings option to HtmlDiff (Closed)

Created:
8 years, 8 months ago by mattsh

Modified:
8 years, 8 months ago

Reviewers:
Bob Nystrom, nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

added printWarnings option to HtmlDiff BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6653

Patch Set 2 : add printWarnings option to HtmlDiff #

Total comments: 2

Patch Set 3 : named argument #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -8 lines)			Patch
	M	utils/apidoc/apidoc.dart	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	utils/apidoc/html_diff.dart	View	1 2	7 chunks	+17 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mattsh

Added a 'printWarnings' option to HtmlDiff to enable us to optionally suppress warnings from DartDoc.

8 years, 8 months ago (2012-04-16 16:49:41 UTC) #1

nweiz

lgtm https://chromiumcodereview.appspot.com/10095017/diff/2001/utils/apidoc/apidoc.dart File utils/apidoc/apidoc.dart (right): https://chromiumcodereview.appspot.com/10095017/diff/2001/utils/apidoc/apidoc.dart#newcode93 utils/apidoc/apidoc.dart:93: _diff = new HtmlDiff(false); I'd prefer "printWarnings: false" ...

8 years, 8 months ago (2012-04-16 18:05:05 UTC) #3