Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 10095009: Make it an error to call close twice on a file using the async API. (Closed)

Created:
8 years, 8 months ago by Mads Ager (google)
Modified:
8 years, 8 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make it an error to call close twice on a file using the async API. This is to make it consistent with the sync API. Additionally, fix situations where a non-exception was passed to error handlers on File objects. R=sgjesse@google.com BUG=dartbug.com/2451 TEST=standalone/io/File* Committed: https://code.google.com/p/dart/source/detail?r=6564

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -121 lines) Patch
M runtime/bin/file_impl.dart View 5 chunks +10 lines, -5 lines 0 comments Download
M tests/standalone/src/io/FileErrorTest.dart View 4 chunks +117 lines, -113 lines 0 comments Download
M tests/standalone/src/io/FileInvalidArgumentsTest.dart View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mads Ager (google)
8 years, 8 months ago (2012-04-16 10:59:12 UTC) #1
Søren Gjesse
8 years, 8 months ago (2012-04-16 11:14:12 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698