Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issue 10094013: Reapply "Use default values of named arguments when invoking the default super constructor." (Closed)

Created:
8 years, 8 months ago by floitsch
Modified:
8 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Use default values of named arguments when invoking the default super constructor." This reapplies (a fixed version of) commit 6580 which had been reverted in commit r6582. Old issue: https://chromiumcodereview.appspot.com//9930005 Committed: https://code.google.com/p/dart/source/detail?r=6583

Patch Set 1 #

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -78 lines) Patch
M lib/compiler/implementation/compile_time_constants.dart View 5 chunks +29 lines, -18 lines 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 10 chunks +81 lines, -48 lines 0 comments Download
M lib/compiler/implementation/universe.dart View 2 chunks +9 lines, -11 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language-leg.status View 1 chunk +0 lines, -1 line 0 comments Download
A tests/language/src/CompileTimeConstantLTest.dart View 1 chunk +26 lines, -0 lines 0 comments Download
A tests/language/src/CompileTimeConstantPTest.dart View 1 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
floitsch
Patchset 1 contains the original CL (without modification). Patchset 2 contains the fix.
8 years, 8 months ago (2012-04-16 14:56:21 UTC) #1
karlklose
8 years, 8 months ago (2012-04-16 14:59:31 UTC) #2
On 2012/04/16 14:56:21, floitsch wrote:
> Patchset 1 contains the original CL (without modification).
> Patchset 2 contains the fix.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698