Issue 10093010: - Free completely empty pages as part of sweep.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10093010: - Free completely empty pages as part of sweep. (Closed)

Created:
8 years, 8 months ago by Ivan Posva

Modified:
8 years, 8 months ago

Reviewers:
Mads Ager (google), cshapiro

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

- Free completely empty pages as part of sweep. Committed: https://code.google.com/p/dart/source/detail?r=6578

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -22 lines)			Patch
	M	vm/pages.h	View	1	2 chunks	+1 line, -1 line	0 comments	Download
	M	vm/pages.cc	View	1	5 chunks	+28 lines, -21 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

Overly aggressive page recycling policy. Better than to hold onto them indefinitely. -Ivan

8 years, 8 months ago (2012-04-16 10:16:24 UTC) #1

Mads Ager (google)

https://chromiumcodereview.appspot.com/10093010/diff/1/vm/pages.cc File vm/pages.cc (right): https://chromiumcodereview.appspot.com/10093010/diff/1/vm/pages.cc#newcode124 vm/pages.cc:124: large_pages_ = page->next(); Shouldn't this be pages_ instead of ...

8 years, 8 months ago (2012-04-16 10:39:08 UTC) #2