Issue 10092012: Fix issue 2358: dart methods on native classes must also check if the current prototype has the met…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10092012: Fix issue 2358: dart methods on native classes must also check if the current prototype has the met… (Closed)

Created:
8 years, 8 months ago by ngeoffray

Modified:
8 years, 8 months ago

Reviewers:
floitsch, kasperl, sra1

CC:
reviews_dartlang.org, Lasse Reichstein Nielsen, ahe, karlklose

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix issue 2358: dart methods on native classes must also check if the current prototype has the method. If not, we need to re-do the dynamic dispatch to actually hit the subclass implementation of the method. Committed: https://code.google.com/p/dart/source/detail?r=6617

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -97 lines)			Patch
M	frog/tests/native/native.status	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	frog/tests/native/src/NativeClassInheritance4FrogTest.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/compiler/implementation/native_emitter.dart	View	1	1 chunk	+6 lines, -19 lines	0 comments	Download
M	lib/compiler/implementation/native_handler.dart	View	1	3 chunks	+50 lines, -73 lines	0 comments	Download
M	lib/compiler/implementation/ssa/codegen.dart	View	1	1 chunk	+21 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://chromiumcodereview.appspot.com/10092012/diff/1/lib/compiler/implementation/ssa/codegen.dart File lib/compiler/implementation/ssa/codegen.dart (right): https://chromiumcodereview.appspot.com/10092012/diff/1/lib/compiler/implementation/ssa/codegen.dart#newcode47 lib/compiler/implementation/ssa/codegen.dart:47: native.generateMethodWithPrototypeCheck( create native.generateMethodWithPrototypeCheckForElement and do the 'if' from ...

8 years, 8 months ago (2012-04-16 17:59:47 UTC) #2

ngeoffray

8 years, 8 months ago (2012-04-17 08:04:18 UTC) #3

Thanks Florian

https://chromiumcodereview.appspot.com/10092012/diff/1/lib/compiler/implement...
File lib/compiler/implementation/ssa/codegen.dart (right):

https://chromiumcodereview.appspot.com/10092012/diff/1/lib/compiler/implement...
lib/compiler/implementation/ssa/codegen.dart:47:
native.generateMethodWithPrototypeCheck(
On 2012/04/16 17:59:47, floitsch wrote:
> create native.generateMethodWithPrototypeCheckForElement and do the 'if' from
> above there.

Done.

Expand Messages | Collapse Messages