Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Issue 10091039: Reapply "Don't try to box immutable objects." (Closed)

Created:
8 years, 8 months ago by floitsch
Modified:
8 years, 8 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Don't try to box immutable objects." This reapplies (a fixed version of) commit 6631 which was reverted in commit 6632. Fix tests (types were wrong). Committed: https://code.google.com/p/dart/source/detail?r=6639

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -4 lines) Patch
M lib/compiler/implementation/ssa/closure.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M samples/tests/samples/samples-leg.status View 1 chunk +0 lines, -1 line 0 comments Download
A tests/language/src/Closure4Test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
A tests/language/src/Closure5Test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
floitsch
Only changed the tests (function 'fun' does not have 'void' return type anymore).
8 years, 8 months ago (2012-04-17 13:35:20 UTC) #1
ngeoffray
8 years, 8 months ago (2012-04-17 13:38:02 UTC) #2
LGTM :-)

Powered by Google App Engine
This is Rietveld 408576698