Issue 10091037: Clean up handling of types.

Issue 10091037: Clean up handling of types. (Closed)

Created:
8 years, 8 months ago by karlklose

Modified:
8 years, 8 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Clean up handling of types. This CL includes changes that address comments in http://codereview.chromium.org/9431029/. - Do not explicitly check for var and Dynamic when resolving types. - Support isSubType on type variables. - Fix reflexivity of interface types. - Check that required classes can be resolved in the core library. Provide all necessay core library classes for DummyCompilerTest.dart and MockCompiler. Committed: https://code.google.com/p/dart/source/detail?r=6671

Patch Set 1 #

Patch Set 2 : Remove debug code. #

Total comments: 3

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+98 lines, -71 lines)			Patch
M	frog/tests/leg/src/ResolverTest.dart	View	1	4 chunks	+24 lines, -10 lines	0 comments	Download
M	frog/tests/leg/src/TypeCheckerTest.dart	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	frog/tests/leg/src/mock_compiler.dart	View		2 chunks	+7 lines, -2 lines	0 comments	Download
M	lib/compiler/implementation/compiler.dart	View		3 chunks	+26 lines, -14 lines	0 comments	Download
M	lib/compiler/implementation/resolver.dart	View		2 chunks	+1 line, -5 lines	0 comments	Download
M	lib/compiler/implementation/typechecker.dart	View	1	6 chunks	+17 lines, -34 lines	3 comments	Download
M	tests/utils/src/DummyCompilerTest.dart	View		1 chunk	+18 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM! https://chromiumcodereview.appspot.com/10091037/diff/3008/lib/compiler/implementation/typechecker.dart File lib/compiler/implementation/typechecker.dart (right): https://chromiumcodereview.appspot.com/10091037/diff/3008/lib/compiler/implementation/typechecker.dart#newcode126 lib/compiler/implementation/typechecker.dart:126: : voidType = new SimpleType(VOID, new ClassElement(VOID, library)), ...

8 years, 8 months ago (2012-04-17 16:14:47 UTC) #2

karlklose

Thanks for the review, Peter. https://chromiumcodereview.appspot.com/10091037/diff/3008/lib/compiler/implementation/typechecker.dart File lib/compiler/implementation/typechecker.dart (right): https://chromiumcodereview.appspot.com/10091037/diff/3008/lib/compiler/implementation/typechecker.dart#newcode126 lib/compiler/implementation/typechecker.dart:126: : voidType = new ...

8 years, 8 months ago (2012-04-18 08:19:08 UTC) #3

ahe

8 years, 8 months ago (2012-04-18 08:49:04 UTC) #4

https://chromiumcodereview.appspot.com/10091037/diff/3008/lib/compiler/implem...
File lib/compiler/implementation/typechecker.dart (right):

https://chromiumcodereview.appspot.com/10091037/diff/3008/lib/compiler/implem...
lib/compiler/implementation/typechecker.dart:126: : voidType = new
SimpleType(VOID, new ClassElement(VOID, library)),
On 2012/04/18 08:19:08, karlklose wrote:
> I am not sure, I added a TODO for now.

Good plan.

Expand Messages | Collapse Messages