Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 10091033: Add extends clause to the type parameter for AbstractScanner. (Closed)

Created:
8 years, 8 months ago by kasperl
Modified:
8 years, 8 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add extends clause to the type parameter for AbstractScanner. This gets rid of a warning when using the result of calling utf8String inside the implementation. R=ahe@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=6627

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M lib/compiler/implementation/scanner/array_based_scanner.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/scanner/scanner.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
kasperl
8 years, 8 months ago (2012-04-17 11:40:37 UTC) #1
ahe
8 years, 8 months ago (2012-04-17 11:45:52 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698