Issue 10091020: Fix fremontcutbuilder bug

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10091020: Fix fremontcutbuilder bug (Closed)

Created:
8 years, 8 months ago by sra1

Modified:
8 years, 8 months ago

Reviewers:
Anton Muhin

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix fremontcutbuilder bug Also regenerate dom.dart Committed: https://code.google.com/p/dart/source/detail?r=6611

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -128 lines)			Patch
	M	lib/dom/dom.dart	View		38 chunks	+79 lines, -127 lines	0 comments	Download
	M	lib/dom/scripts/fremontcutbuilder.py	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

8 years, 8 months ago (2012-04-17 11:05:58 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10091020/diff/1/lib/dom/scripts/fremon...
File lib/dom/scripts/fremontcutbuilder.py (right):

https://chromiumcodereview.appspot.com/10091020/diff/1/lib/dom/scripts/fremon...
lib/dom/scripts/fremontcutbuilder.py:202: idl_files.append(file_name)
thanks a lot and sorry

Expand Messages | Collapse Messages