Issue 10086015: Fix bug 918

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10086015: Fix bug 918 (Closed)

Created:
8 years, 8 months ago by hausner

Modified:
8 years, 8 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix bug 918 Don't choke to top-level native function declarations. Committed: https://code.google.com/p/dart/source/detail?r=6541

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -13 lines)			Patch
	M	runtime/vm/parser.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	runtime/vm/parser.cc	View		2 chunks	+29 lines, -12 lines	0 comments	Download

Total messages: 3 (0 generated)

srdjan

LGTM, but please add tests that demonstrates what was fixed

8 years, 8 months ago (2012-04-13 21:50:08 UTC) #2

As discussed, saving this for a rainy day.