Issue 10084015: Fix firefox install on setup script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10084015: Fix firefox install on setup script. (Closed)

Created:
8 years, 8 months ago by Emily Fortuna

Modified:
8 years, 8 months ago

Reviewers:
Siggi Cherem (dart-lang), Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix firefox install on setup script. Committed: https://code.google.com/p/dart/source/detail?r=6539

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tools/testing/webdriver_test_setup.py	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

8 years, 8 months ago (2012-04-13 18:19:48 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10084015/diff/2001/tools/testing/webdr...
File tools/testing/webdriver_test_setup.py (right):

https://chromiumcodereview.appspot.com/10084015/diff/2001/tools/testing/webdr...
tools/testing/webdriver_test_setup.py:160: @property
do you believe in magic? and I hope you do!

Expand Messages | Collapse Messages